From 3c9079ab54973f9703a2522921b176fb34b6dd09 Mon Sep 17 00:00:00 2001
From: Pino Toscano <pino@kde.org>
Date: Wed, 28 Feb 2007 23:21:15 +0000
Subject: [PATCH] misc stuff, like explicit for constructors, constness,
 pass-by-const-ref, etc

svn path=/trunk/KDE/kdeedu/libkdeedu/; revision=638143
---
 kdeeducore/keduvocdocument.cpp     | 2 +-
 kdeeducore/keduvocdocument.h       | 2 +-
 kdeeducore/keduvocexpression.h     | 4 ++--
 kdeeducore/keduvocpaukerreader.cpp | 2 +-
 kdeeducore/leitnerbox.cpp          | 2 +-
 kdeeducore/leitnerbox.h            | 4 ++--
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/kdeeducore/keduvocdocument.cpp b/kdeeducore/keduvocdocument.cpp
index f00b3a0..31cd4b0 100644
--- a/kdeeducore/keduvocdocument.cpp
+++ b/kdeeducore/keduvocdocument.cpp
@@ -856,7 +856,7 @@ QList<int> KEduVocDocument::lessonsInQuery() const
 }
 
 
-void KEduVocDocument::setLessonsInQuery(QList<int> lesson_iq)
+void KEduVocDocument::setLessonsInQuery(const QList<int> &lesson_iq)
 {
   d->m_lessonsInQuery.clear();
   for (int i = 0; i < d->m_lessonDescriptions.count(); i++)
diff --git a/kdeeducore/keduvocdocument.h b/kdeeducore/keduvocdocument.h
index 9b4ea55..51a7f98 100644
--- a/kdeeducore/keduvocdocument.h
+++ b/kdeeducore/keduvocdocument.h
@@ -657,7 +657,7 @@ public:
   /**
    * Sets the lessons in the current query
    */
-  void setLessonsInQuery(QList<int>);
+  void setLessonsInQuery(const QList<int> &lesson_iq);
 
   QStringList lessonDescriptions() const;
 
diff --git a/kdeeducore/keduvocexpression.h b/kdeeducore/keduvocexpression.h
index 0985188..43e9370 100644
--- a/kdeeducore/keduvocexpression.h
+++ b/kdeeducore/keduvocexpression.h
@@ -70,14 +70,14 @@ public:
 
   /** default constructor for an empty vocabulary expression
    */
-  KEduVocExpression();
+  explicit KEduVocExpression();
 
   /** Constructor for a vocabulary expression with an original
    *
    * @param expression       original
    * @param lesson           lesson number, 0 for none
    */
-  KEduVocExpression(const QString & expression, int lesson = 0);
+  explicit KEduVocExpression(const QString & expression, int lesson = 0);
 
   /** Constructor for a vocabulary expression with an original and one or more translations
    *
diff --git a/kdeeducore/keduvocpaukerreader.cpp b/kdeeducore/keduvocpaukerreader.cpp
index a79e5d3..c596b52 100644
--- a/kdeeducore/keduvocpaukerreader.cpp
+++ b/kdeeducore/keduvocpaukerreader.cpp
@@ -75,6 +75,6 @@ QString KEduVocPaukerReader::cardText(const QDomNode & entry, const QString & ta
   if(!element.isNull())
     return element.text();
   else
-    return QString::null;
+    return QString();
 }
 
diff --git a/kdeeducore/leitnerbox.cpp b/kdeeducore/leitnerbox.cpp
index a96d7c4..eef1e5d 100644
--- a/kdeeducore/leitnerbox.cpp
+++ b/kdeeducore/leitnerbox.cpp
@@ -20,7 +20,7 @@ LeitnerBox::~LeitnerBox()
 {
 }
 
-int LeitnerBox::vocabCount()
+int LeitnerBox::vocabCount() const
 {
 	return m_vocabCount;
 }
diff --git a/kdeeducore/leitnerbox.h b/kdeeducore/leitnerbox.h
index 1767eb7..7e74413 100644
--- a/kdeeducore/leitnerbox.h
+++ b/kdeeducore/leitnerbox.h
@@ -39,7 +39,7 @@ public:
 	/**
 	 * The constructor
 	 */
-	LeitnerBox();
+	explicit LeitnerBox();
 
 	/**
 	 * The destructor
@@ -81,7 +81,7 @@ public:
 	 * Returns the current vocabCount
 	 * @return the number of cards/ vocabs that are currently assigned to the LeitnerBox.
 	 */
-	int vocabCount();
+	int vocabCount() const;
 
 	/**
 	 * Returns a pointer to the LeitnerBox correct cards of this LeitnerBox here are assigned to
-- 
2.47.3