From 2988afae28e4c16fef2ebc8ec399e9111148031b Mon Sep 17 00:00:00 2001 From: Jason Harris Date: Fri, 15 Sep 2006 21:45:57 +0000 Subject: [PATCH] Fixed crash condition in ExtDate::fromString(QString, QDateFormat). When using the TextFormat QDateFormat, the code creates a QStringList from the space-separated fields of the input string, but it then assumed that the stringlist contains at least three members, which caused a crash when this was not the case. Now, it will return an invalid ExtDate if the stringlist contains fewer than three members. Thanks for the tip, Jasem. CCMAIL: kde-edu@kde.org CCMAIL: kstars-devel@kde.org svn path=/trunk/KDE/kdeedu/libkdeedu/; revision=584944 --- extdate/extdatetime.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/extdate/extdatetime.cpp b/extdate/extdatetime.cpp index 128959d..8c8f127 100644 --- a/extdate/extdatetime.cpp +++ b/extdate/extdatetime.cpp @@ -494,6 +494,10 @@ ExtDate ExtDate::fromString( const QString& s, Qt::DateFormat f ) //Three possible date formats: //dd mth yyyy; mth dd yyyy; wkd mth dd yyyy QStringList ss = s.split( " " ); + + //Return invalid if we don't have at least 3 fields + if ( ss.size() < 3 ) return dt; + bool ok = false; int month = -1; uint imonth = 0; -- 2.47.3