From: Frederik Gladhorn <gladhorn@kde.org>
Date: Wed, 12 Sep 2007 19:22:48 +0000 (+0000)
Subject: Get rid of the m_inQuery for KEduVocExpression.
X-Git-Tag: v3.94.0~58
X-Git-Url: https://git.rmz.fi/?a=commitdiff_plain;h=b8167d14c43b5c68852758a531bcd54880c5d840;p=libqmvoc.git

Get rid of the m_inQuery for KEduVocExpression.
Only KVoc used to use it and it will just no longer be used.
It had no meaning for quite a while in parley, only confusing things.
The main table now only shows (in)active for the words.
(the chainsaw was here...)

svn path=/trunk/KDE/kdeedu/libkdeedu/; revision=711774
---

diff --git a/keduvocdocument/keduvocdocument.h b/keduvocdocument/keduvocdocument.h
index a44ef1a..0e4d0cf 100644
--- a/keduvocdocument/keduvocdocument.h
+++ b/keduvocdocument/keduvocdocument.h
@@ -237,11 +237,9 @@ public:
     /**
      * Appends a new identifier (usually a language)
      *
-     * @param name the identifier to append
+     * @param identifier the identifier to append. If empty default names are used.
      * @returns the identifier number
      */
-//     int appendIdentifier( const QString& name );
-
     int appendIdentifier( const KEduVocIdentifier & identifier = KEduVocIdentifier());
 
     /**
@@ -258,7 +256,6 @@ public:
      * @param index            number of translation 0..x
      * @returns                the language identifier: en=english, de=german, ...
      */
-//     QString identifier( int index ) const;
     KEduVocIdentifier& identifier( int index );
 
     /**
diff --git a/keduvocdocument/keduvocexpression.cpp b/keduvocdocument/keduvocexpression.cpp
index 9462390..46bfac3 100644
--- a/keduvocdocument/keduvocexpression.cpp
+++ b/keduvocdocument/keduvocexpression.cpp
@@ -39,7 +39,6 @@ public:
     QString m_leitnerBox;
     int m_sortIndex;
     int m_lesson;
-    bool m_inQuery;
     bool m_active;
     int m_sizeHint;
 
@@ -50,8 +49,6 @@ public:
 void KEduVocExpression::KEduVocExpressionPrivate::init()
 {
     m_translations.clear();
-
-    m_inQuery = false;
     m_active = true;
     m_lesson = -1;
     m_sortIndex = 0;
@@ -66,7 +63,6 @@ bool KEduVocExpression::KEduVocExpressionPrivate::operator== ( const KEduVocExpr
         m_leitnerBox == p.m_leitnerBox &&
         m_lesson == p.m_lesson &&
         m_sortIndex == p.m_sortIndex &&
-        m_inQuery == p.m_inQuery &&
         m_active == p.m_active;
 }
 
@@ -140,18 +136,6 @@ void KEduVocExpression::setLeitnerBox( const QString& box )
 }
 
 
-bool KEduVocExpression::isInQuery() const
-{
-    return d->m_inQuery;
-}
-
-
-void KEduVocExpression::setInQuery( bool flag )
-{
-    d->m_inQuery = flag;
-}
-
-
 bool KEduVocExpression::isActive() const
 {
     return d->m_active;
diff --git a/keduvocdocument/keduvocexpression.h b/keduvocdocument/keduvocexpression.h
index 10ecef4..5520f25 100644
--- a/keduvocdocument/keduvocexpression.h
+++ b/keduvocdocument/keduvocexpression.h
@@ -70,14 +70,6 @@ public:
      */
     void resetGrades( int index );
 
-    /** returns flag if entry is "selected" for queries
-     */
-    bool isInQuery() const;
-
-    /** set entry "selected"
-     */
-    void setInQuery( bool flag = true );
-
     /** returns flag if entry is activated for queries
      */
     bool isActive() const;
diff --git a/keduvocdocument/keduvockvtml2reader.cpp b/keduvocdocument/keduvockvtml2reader.cpp
index 5890fb1..37ba4dd 100644
--- a/keduvocdocument/keduvockvtml2reader.cpp
+++ b/keduvocdocument/keduvockvtml2reader.cpp
@@ -276,15 +276,15 @@ bool KEduVocKvtml2Reader::readEntry( QDomElement &entryElement )
         }
     }
 
-    currentElement = entryElement.firstChildElement( KVTML_INQUERY );
-    if ( !currentElement.isNull() ) {
-        // set the inquery information
-        if ( currentElement.text() == KVTML_TRUE ) {
-            expr.setInQuery( true );
-        } else {
-            expr.setInQuery( false );
-        }
-    }
+//     currentElement = entryElement.firstChildElement( KVTML_INQUERY );
+//     if ( !currentElement.isNull() ) {
+//         // set the inquery information
+//         if ( currentElement.text() == KVTML_TRUE ) {
+//             expr.setInQuery( true );
+//         } else {
+//             expr.setInQuery( false );
+//         }
+//     }
 
     currentElement = entryElement.firstChildElement( KVTML_SIZEHINT );
     if ( !currentElement.isNull() ) {
diff --git a/keduvocdocument/keduvockvtml2writer.cpp b/keduvocdocument/keduvockvtml2writer.cpp
index 2dc621d..4435c2f 100644
--- a/keduvocdocument/keduvockvtml2writer.cpp
+++ b/keduvocdocument/keduvockvtml2writer.cpp
@@ -325,8 +325,9 @@ bool KEduVocKvtml2Writer::writeEntries( QDomElement &entriesElement )
         // write inactive
         entryElement.appendChild( newTextElement( KVTML_INACTIVE, thisEntry->isActive() ? KVTML_FALSE : KVTML_TRUE ) );
 
-        // write inquery
-        entryElement.appendChild( newTextElement( KVTML_INQUERY, thisEntry->isInQuery() ? KVTML_TRUE : KVTML_FALSE ) );
+// kvtml 1 relic no longer used
+//         // write inquery
+//         entryElement.appendChild( newTextElement( KVTML_INQUERY, thisEntry->isInQuery() ? KVTML_TRUE : KVTML_FALSE ) );
 
         // write sizehint
         if ( thisEntry->sizeHint() > 0 ) {
diff --git a/keduvocdocument/keduvockvtmlcompability.cpp b/keduvocdocument/keduvockvtmlcompability.cpp
index 3897b97..4ff9d31 100644
--- a/keduvocdocument/keduvockvtmlcompability.cpp
+++ b/keduvocdocument/keduvockvtmlcompability.cpp
@@ -261,4 +261,4 @@ QString KEduVocKvtmlCompability::oldTense(const QString & tense)
         m_oldTenses[KVTML_1_USER_DEFINED + QString::number( m_userdefinedTenseCounter )] = tense;
     }
     return m_oldTenses.key(tense);
-}
\ No newline at end of file
+}
diff --git a/keduvocdocument/keduvockvtmlreader.cpp b/keduvocdocument/keduvockvtmlreader.cpp
index 43af42e..637d342 100644
--- a/keduvocdocument/keduvockvtmlreader.cpp
+++ b/keduvocdocument/keduvockvtmlreader.cpp
@@ -1005,7 +1005,9 @@ bool KEduVocKvtmlReader::readExpression( QDomElement &domElementParent )
         if ( i == 0 ) {
             expr = KEduVocExpression( textstr );
             expr.setLesson( lesson );
-            expr.setInQuery( inquery );
+
+///@todo inquery is old and no longer used. get rid of reading it.
+//             expr.setInQuery( inquery );
             expr.setActive( active );
         } else {
             expr.setTranslation( i, textstr );
@@ -1070,9 +1072,9 @@ bool KEduVocKvtmlReader::readExpression( QDomElement &domElementParent )
         i++;
     }
 
-    if ( m_doc->entryCount() == 0 ) {
-        m_doc->setQueryIdentifier( q_org, q_trans );
-    }
+//     if ( m_doc->entryCount() == 0 ) {
+//         m_doc->setQueryIdentifier( q_org, q_trans );
+//     }
     m_doc->appendEntry( &expr );
 
     // also add this entryid to the lesson it's part of
diff --git a/keduvocdocument/keduvockvtmlwriter.cpp b/keduvocdocument/keduvockvtmlwriter.cpp
index 5cc34bd..629fa66 100644
--- a/keduvocdocument/keduvockvtmlwriter.cpp
+++ b/keduvocdocument/keduvockvtmlwriter.cpp
@@ -108,8 +108,9 @@ bool KEduVocKvtmlWriter::writeDoc( KEduVocDocument *doc, const QString &generato
             domElementExpression.setAttribute( KV_LESS_MEMBER, lm );
         }
 
-        if ( entry->isInQuery() )
-            domElementExpression.setAttribute( KV_SELECTED, 1 );
+// Sorry, but we don't support this any more.
+//         if ( entry->isInQuery() )
+//             domElementExpression.setAttribute( KV_SELECTED, 1 );
 
         if ( !entry->isActive() )
             domElementExpression.setAttribute( KV_INACTIVE, 1 );