From: Frederik Gladhorn <gladhorn@kde.org>
Date: Sun, 24 Feb 2008 20:34:05 +0000 (+0000)
Subject: more reader/writer cleanup
X-Git-Tag: v4.0.71~37
X-Git-Url: https://git.rmz.fi/?a=commitdiff_plain;h=626f86b7863683a8829bff2b884564f992d92a90;p=libqmvoc.git

more reader/writer cleanup

svn path=/trunk/KDE/kdeedu/libkdeedu/; revision=778893
---

diff --git a/keduvocdocument/keduvockvtml2reader.cpp b/keduvocdocument/keduvockvtml2reader.cpp
index 52d1c76..08f6d6e 100644
--- a/keduvocdocument/keduvockvtml2reader.cpp
+++ b/keduvocdocument/keduvockvtml2reader.cpp
@@ -309,48 +309,13 @@ bool KEduVocKvtml2Reader::readTranslation( QDomElement &translationElement,
 {
     expr->translation(index)->fromKVTML2(translationElement);
 
-    QDomElement currentElement = translationElement.firstChildElement( KVTML_COMMENT );
-    if ( !currentElement.isNull() ) {
-        expr->translation(index)->setComment( currentElement.text() );
-    }
-
-    //<pronunciation></pronunciation>
-    currentElement = translationElement.firstChildElement( KVTML_PRONUNCIATION );
-    if ( !currentElement.isNull() ) {
-        expr->translation(index)->setPronunciation( currentElement.text() );
-    }
-
     //<falsefriend fromid="1"></falsefriend>
-    currentElement = translationElement.firstChildElement( KVTML_FALSEFRIEND );
+    QDomElement currentElement = translationElement.firstChildElement( KVTML_FALSEFRIEND );
     if ( !currentElement.isNull() ) {
         int fromid = currentElement.attribute( KVTML_FROMID ).toInt();
         expr->translation(index)->setFalseFriend( fromid, currentElement.text() );
     }
 
-    //<antonym></antonym>
-    currentElement = translationElement.firstChildElement( KVTML_ANTONYM );
-    if ( !currentElement.isNull() ) {
-        expr->translation(index)->setAntonym( currentElement.text() );
-    }
-
-    //<synonym></synonym>
-    currentElement = translationElement.firstChildElement( KVTML_SYNONYM );
-    if ( !currentElement.isNull() ) {
-        expr->translation(index)->setSynonym( currentElement.text() );
-    }
-
-    //<example></example>
-    currentElement = translationElement.firstChildElement( KVTML_EXAMPLE );
-    if ( !currentElement.isNull() ) {
-        expr->translation(index)->setExample( currentElement.text() );
-    }
-
-    //<paraphrase></paraphrase>
-    currentElement = translationElement.firstChildElement( KVTML_PARAPHRASE );
-    if ( !currentElement.isNull() ) {
-        expr->translation(index)->setParaphrase( currentElement.text() );
-    }
-
     // conjugations
     currentElement = translationElement.firstChildElement( KVTML_CONJUGATION );
     while ( !currentElement.isNull() ) {
@@ -363,14 +328,6 @@ bool KEduVocKvtml2Reader::readTranslation( QDomElement &translationElement,
         currentElement = currentElement.nextSiblingElement( KVTML_CONJUGATION );
     }
 
-    // grade elements
-    currentElement = translationElement.firstChildElement( KVTML_GRADE );
-    while ( !currentElement.isNull() ) {
-        // TODO: read grade
-        readGrade( currentElement, expr, index );
-        currentElement = currentElement.nextSiblingElement( KVTML_GRADE );
-    }
-
     // comparisons
     currentElement = translationElement.firstChildElement( KVTML_COMPARISON );
     if ( !currentElement.isNull() ) {
@@ -650,45 +607,6 @@ bool KEduVocKvtml2Reader::readMultipleChoice( QDomElement &multipleChoiceElement
     return true;
 }
 
-bool KEduVocKvtml2Reader::readGrade( QDomElement &gradeElement, KEduVocExpression *expr, int index )
-{
-    bool result = true;
-    if ( !result ) {
-        m_errorMessage = i18n( "identifier missing id" );
-        return false;
-    }
-
-    QDomElement currentElement = gradeElement.firstChildElement( KVTML_CURRENTGRADE );
-    if ( !currentElement.isNull() ) {
-        int value = currentElement.text().toInt();
-        expr->translation(index)->setGrade( value );
-    }
-
-    currentElement = gradeElement.firstChildElement( KVTML_COUNT );
-    if ( !currentElement.isNull() ) {
-        int value = currentElement.text().toInt();
-        expr->translation(index)->setPracticeCount( value );
-    }
-
-    currentElement = gradeElement.firstChildElement( KVTML_ERRORCOUNT );
-    if ( !currentElement.isNull() ) {
-        int value = currentElement.text().toInt();
-        expr->translation(index)->setBadCount( value );
-    }
-
-    currentElement = gradeElement.firstChildElement( KVTML_DATE );
-    if ( !currentElement.isNull() ) {
-        QString dateString = currentElement.text();
-        if ( !dateString.isEmpty() ) {
-            QDateTime value = QDateTime::fromString( dateString, Qt::ISODate );
-            expr->translation(index)->setPracticeDate( value );
-        }
-    }
-
-    return true;
-}
-
-
 bool KEduVocKvtml2Reader::readConjugation( QDomElement &conjugElement, KEduVocConjugation &conjugation )
 /*
  <conjugation>
diff --git a/keduvocdocument/keduvoclesson.h b/keduvocdocument/keduvoclesson.h
index e8c5627..060c4aa 100644
--- a/keduvocdocument/keduvoclesson.h
+++ b/keduvocdocument/keduvoclesson.h
@@ -49,7 +49,6 @@ public:
     /** assignment operator */
     KEduVocLesson& operator= ( const KEduVocLesson& );
 
-
     KEduVocExpression* entry(int row, EnumEntriesRecursive recursive = NotRecursive);
 
     /** get a list of all entries in the lesson */
diff --git a/keduvocdocument/keduvoctext.cpp b/keduvocdocument/keduvoctext.cpp
index cf1feb2..6a4f410 100644
--- a/keduvocdocument/keduvoctext.cpp
+++ b/keduvocdocument/keduvoctext.cpp
@@ -203,4 +203,21 @@ void KEduVocText::toKVTML2(QDomElement& parent)
 void KEduVocText::fromKVTML2(QDomElement & parent)
 {
     setText( parent.firstChildElement( KVTML_TEXT ).text() );
+
+    // grade element
+    parent.firstChildElement() = parent.firstChildElement( KVTML_GRADE );
+    if ( !parent.firstChildElement().isNull() ) {
+
+        setGrade( parent.firstChildElement(KVTML_CURRENTGRADE).text().toInt() );
+
+        setPracticeCount( parent.firstChildElement(KVTML_COUNT).text().toInt() );
+
+        setBadCount( parent.firstChildElement(KVTML_ERRORCOUNT).text().toInt() );
+
+        QString dateString = parent.firstChildElement(KVTML_DATE).text();
+        if ( !dateString.isEmpty() ) {
+            QDateTime value = QDateTime::fromString( dateString, Qt::ISODate );
+            setPracticeDate( value );
+        }
+    }
 }
diff --git a/keduvocdocument/keduvoctranslation.cpp b/keduvocdocument/keduvoctranslation.cpp
index 9016377..466ebff 100644
--- a/keduvocdocument/keduvoctranslation.cpp
+++ b/keduvocdocument/keduvoctranslation.cpp
@@ -384,3 +384,25 @@ void KEduVocTranslation::toKVTML2(QDomElement & parent)
     KEduVocKvtml2Writer::appendTextElement( parent, KVTML_PARAPHRASE, paraphrase() );
 }
 
+void KEduVocTranslation::fromKVTML2(QDomElement & parent)
+{
+    KEduVocText::fromKVTML2(parent);
+
+    setComment( parent.firstChildElement( KVTML_COMMENT ).text() );
+
+    setPronunciation( parent.firstChildElement( KVTML_PRONUNCIATION ).text() );
+
+    //<antonym></antonym>
+    setAntonym( parent.firstChildElement( KVTML_ANTONYM ).text() );
+
+    //<synonym></synonym>
+    setSynonym( parent.firstChildElement( KVTML_SYNONYM ).text() );
+
+    //<example></example>
+    setExample( parent.firstChildElement( KVTML_EXAMPLE ).text() );
+
+    //<paraphrase></paraphrase>
+    setParaphrase( parent.firstChildElement( KVTML_PARAPHRASE ).text() );
+
+}
+
diff --git a/keduvocdocument/keduvoctranslation.h b/keduvocdocument/keduvoctranslation.h
index 3096365..1e0b5bb 100644
--- a/keduvocdocument/keduvoctranslation.h
+++ b/keduvocdocument/keduvoctranslation.h
@@ -235,7 +235,7 @@ public:
      */
     bool operator== ( const KEduVocTranslation &translation ) const;
 
-//     void fromKVTML2(QDomElement& parent);
+    void fromKVTML2(QDomElement& parent);
     void toKVTML2(QDomElement& parent);
 
 private: