Some fixes according to Benjamin Meyer's tests.

svn path=/trunk/KDE/kdeedu/kalzium/src/element.cpp; revision=417793

diff --git a/kalzium/src/element.cpp b/kalzium/src/element.cpp
index 9c4b95918fa52888275d5657e21200c55ffb7609..925c99f318b242beb29736e023ac3511619b2453 100644 (file)
--- a/kalzium/src/element.cpp
+++ b/kalzium/src/element.cpp
@@ -335,7 +335,7 @@ void Element::drawHighlight( QPainter* p, int coordinate, bool horizontal )
        drawSelf( p, false );
 }
        
-void Element::drawGradient( QPainter* p, const QString& value, const QColor c)
+void Element::drawGradient( QPainter* p, const QString& value, const QColor& c)
 {
        //the height of a "line" inside an element
        int h_small = 15; //the size for the small units like elementnumber

diff --git a/kalzium/src/element.h b/kalzium/src/element.h
index b313333f79904631b89572cf71f00870166e6221..1b29e6cfbf9fd9479437be286bb589b89452891b 100644 (file)
--- a/kalzium/src/element.h
+++ b/kalzium/src/element.h
@@ -96,16 +96,16 @@ class Element{
                void setAggregation( int value ) { m_az = value; }
                void setNumber( int num ){ m_number = num; }
 
-               void setScientist( QString value ) { m_scientist = value; }
-               void setName( QString value ) { m_name = value; }
-               void setBlock( QString value ) { m_block = value; }
-               void setGroup( QString value ) { m_group = value; }
-               void setFamily( QString value ) { m_family = value; }
-               void setOrbits( QString value ) { m_orbits = value; }
-               void setSymbol( QString value ) { m_symbol = value; }
-               void setOxydation( QString value ) { m_oxstage = value; }
-               void setAcidicbehaviour( QString value ) { m_acidbeh = value; }
-               void setIsotopes( QString value ) { m_isotopes = value; }
+               void setScientist( const QString& value ) { m_scientist = value; }
+               void setName( const QString& value ) { m_name = value; }
+               void setBlock( const QString& value ) { m_block = value; }
+               void setGroup( const QString& value ) { m_group = value; }
+               void setFamily( const QString& value ) { m_family = value; }
+               void setOrbits( const QString& value ) { m_orbits = value; }
+               void setSymbol( const QString& value ) { m_symbol = value; }
+               void setOxydation( const QString& value ) { m_oxstage = value; }
+               void setAcidicbehaviour( const QString& value ) { m_acidbeh = value; }
+               void setIsotopes( const QString& value ) { m_isotopes = value; }
 
                void setIonisationList( doubleList l ){
                        m_ionenergies = l;
@@ -349,7 +349,7 @@ class Element{
                 * draw the recatangle with the information
                 * @param showFullInformation if True more information will be shown
                 */
-               virtual void drawGradient( QPainter* p, const QString& value, const QColor );
+               virtual void drawGradient( QPainter* p, const QString& value, const QColor& );
                
                virtual void drawSelf( QPainter* p, bool showFullInformation );